fix: Prevent lockfile overwrite loops on metadata fetch #20244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
|
Oh, it's mandatory to have lockfile names as |
ShoyuVanilla
force-pushed
the
lockfile-mess
branch
from
f182c33 to
20f2c76
Compare
ShoyuVanilla
force-pushed
the
lockfile-mess
branch
from
20f2c76 to
396f0b5
Compare
rustbot
added
the
S-waiting-on-review
|
Some thoughts on this: #t-compiler/rust-analyzer > Do we need copied lockfiles? |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20189
This is not ideal because this ad-hoc filtering in
crates/rust-analyzer/src/reload.rsmight diverge fromcrates/project-model/src/cargo_workspace.rsbut I couldn't find better way 😢 and as this hangs rust-analyzer totally from startup for some people, I thought this must be fixed ASAP